fix: fix function object returned from RPC to be a callable - #160
Open
ryanking13 wants to merge 1 commit into
Open
fix: fix function object returned from RPC to be a callable#160ryanking13 wants to merge 1 commit into
ryanking13 wants to merge 1 commit into
Conversation
|
The code looks solid. Let me verify one more thing about the The
The tests are well-structured and cover:
The test files import Everything here looks correct and well-tested. The changes are minimal and focused on the two bugs described in the PR. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some bugs related to RPC calls, that I noticed while checking RPC docs examples.
bool(binding)was failing because the Python class fallbacks tolen()call when there is no__bool__implemented.