Open
Conversation
chreo
reviewed
Jan 20, 2026
kerolasa
added a commit
to kerolasa/tableflip
that referenced
this pull request
Jan 21, 2026
When an initial working directory fails to populate upgrades will fail even when user supplied pid file is defined. This change fixes the issue. Also add more information to error messages as a consequence of pull review. Reviewed-by: Christian Elmerot <christian@elmerot.se> Reference: cloudflare#85 (comment) Signed-off-by: Sami Kerola <kerolasa@cloudflare.com>
kerolasa
force-pushed
the
kerolasa/init-wd
branch
from
7cb1278 to
880e3ac
Compare
Signed-off-by: Sami Kerola <kerolasa@cloudflare.com>
Reference: https://pkg.go.dev/io/ioutil Signed-off-by: Sami Kerola <kerolasa@cloudflare.com>
When an initial working directory fails to populate upgrades will fail even when user supplied pid file is defined. This change fixes the issue. Also add more information to error messages as a consequence of pull review. Reviewed-by: Christian Elmerot <christian@elmerot.se> Reference: cloudflare#85 (comment) Signed-off-by: Sami Kerola <kerolasa@cloudflare.com>
The build failed with following message.
Run test -z "$(gofmt -l ./ | tee /dev/stderr)"
doc.go
Error: Process completed with exit code 1.F
Signed-off-by: Sami Kerola <kerolasa@cloudflare.com>
kerolasa
force-pushed
the
kerolasa/init-wd
branch
from
880e3ac to
62263f5
Compare
When sending my earlier changes to review test failed with following message.
--- FAIL: TestFdsFiles (0.00s)
fds_test.go:451: Expected file "fd:test1:", got "fd:test2:"
fds_test.go:451: Expected file "fd:test2:", got "fd:test1:"
It turns out one cannot trust order of items in a golang map. It is best to
sort the output so that results are a stable set. Notice that I chose sorting
the test results, not what code is generating. On a real system order of these
items should not matter, so there is no point to spend time sorting them.
Reference: https://github.com/cloudflare/tableflip/pull/85/files
Signed-off-by: Sami Kerola <kerolasa@cloudflare.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: fix gofmt test failure
The build failed with following message.
Signed-off-by: Sami Kerola kerolasa@cloudflare.com
DNS-12599: avoid failing upgrade due to initWD being empty
When an initial working directory fails to populate upgrades will fail even
when user supplied pid file is defined. This change fixes the issue.
Also add more information to error messages as a consequence of pull review.
Reviewed-by: Christian Elmerot christian@elmerot.se
Reference: Kerolasa/init wd #85 (comment)
Signed-off-by: Sami Kerola kerolasa@cloudflare.com
chore: do not use deprecated ioutls package
Reference: https://pkg.go.dev/io/ioutil
Signed-off-by: Sami Kerola kerolasa@cloudflare.com
chore: vendor update 2026-01-13
Signed-off-by: Sami Kerola kerolasa@cloudflare.com