Merged
Conversation
Co-authored-by: Brayden <Brayden@users.noreply.github.com>
commit: |
Contributor
Docs PreviewCommit: |
Contributor
geoquant
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





















All tests pass. Let me provide a summary of the changes:
Summary
I fixed the issue where
Selectcomponent'sdescriptionanderrorprops were being silently ignored whenhideLabelwastrue(the default).Changes Made
1.
packages/kumo/src/components/select/select.tsxdescriptionanderrorelementshideLabelis true, the component now renders:sr-only) label for accessibilitytext-kumo-danger) or a description (styled withtext-kumo-subtle)<span>elements with the same styling as the Field component uses2.
packages/kumo/src/components/select/select.test.tsx(new file)hideLabelis true (default)hideLabelis explicitly truehideLabelis false3.
.changeset/fix-select-description-hidelabel.md(new file)Before/After
Before: When using
<Select label="DB" description="Select your preferred database">, the description was silently ignored becausehideLabeldefaults totrue.After: The description now renders below the select control, maintaining the same styling as when
hideLabel={false}.Closes #150
github run