Skip to content

Reject invalid ingress hostname wildcards - #1801

Open
BenjaminMitchell-D0FB wants to merge 1 commit into
cloudflare:masterfrom
BenjaminMitchell-D0FB:BenjaminMitchell-D0FB/fix-ingress-hostname-wildcard
Open

BenjaminMitchell-D0FB wants to merge 1 commit into
cloudflare:masterfrom
BenjaminMitchell-D0FB:BenjaminMitchell-D0FB/fix-ingress-hostname-wildcard

Conversation

@BenjaminMitchell-D0FB

Copy link
Copy Markdown

Summary

  • Reject partial-label wildcard hostnames such as *app.example.com
    and wildcard patterns with no suffix, such as *..
  • Preserve support for subdomain wildcards such as *.example.com
    and the standalone * catch-all.

Testing

  • Added regression coverage for invalid wildcard patterns and verified
    that supported wildcard patterns still pass ingress validation.
  • make test and make lint passed.

Fixes #1800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛Ingress validation accepts a hostname wildcard that never matches the intended subdomain

1 participant