fix: TestSupportedCurvesNegotiation fails with standard Go on Linux - #1704
Open
RajeshRajendiran wants to merge 1 commit into
Open
fix: TestSupportedCurvesNegotiation fails with standard Go on Linux#1704RajeshRajendiran wants to merge 1 commit into
RajeshRajendiran wants to merge 1 commit into
Conversation
P256Kyber768Draft00 is a private curve ID implemented by Cloudflare's Go fork, not a property of the linux GOOS. Standard crypto/tls filters the unknown ID out of the ClientHello, so the test's GOOS-based check failed on a standard Go toolchain. Detect the toolchain by checking whether the curve was actually advertised instead. Fixes cloudflare#1700
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestSupportedCurvesNegotiationusedruntime.GOOS == "linux"as a proxy for whether the TLS stack supports Cloudflare's privateP256Kyber768Draft00curve. That curve is implemented by Cloudflare's Go fork, not by the standardcrypto/tlspackage, so the test fails under a standard Go toolchain on Linux (the setup documented in the README for external contributors).Fix
P256Kyber768Draft00actually appears in the advertised curves, rather than inferring it fromGOOS.Test plan
go test -mod=vendor -race -count=1 -run TestSupportedCurvesNegotiation -v ./cryptopasses on standard Go 1.26.0 linux/arm64go test -mod=vendor -race -count=1 -v ./crypto/...passes (full package)go vet ./crypto/...go build ./...Fixes #1700