Remove stale documentation claiming stdin support for exec(), execStream(), and startProcess() - #32391
Open
thazhemadam wants to merge 1 commit into
Open
Remove stale documentation claiming stdin support for exec(), execStream(), and startProcess() #32391thazhemadam wants to merge 1 commit into
thazhemadam wants to merge 1 commit into
Conversation
Contributor
Review
👉 Fix in your agent 👈Fix the following review findings in PR #32391 (https://github.com/cloudflare/cloudflare-docs/pull/32391).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Warnings (1)
#### CR-ccb6ef133f6d · Incomplete removal of stale stdin documentation
- **File:** `src/content/docs/sandbox/api/commands.mdx` line 117
- **Issue:** The `startProcess()` options still list `stdin` with the description "Data to pass to the command's standard input". The PR title states it removes stale stdin support documentation from `exec()`, `execStream()`, and `startProcess()`.
- **Fix:** Remove the `stdin` bullet from the `startProcess()` options if stdin is unsupported there, or update the PR title/description if `startProcess()` still supports stdin.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (1)
ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
…am(), and startProcess() (cloudflare#27850)" This reverts merge commit b56f39e. Remove stale documentation claiming that `exec()`, `execStream()`, and `startProcess()` accept `stdin` input. The documentation was added in cloudflare-docs#27850 to match cloudflare/sandbox-sdk#362, but the SDK change was closed without merging in favor of a future PTY-based design. The released SDK does not expose this option, so the current examples direct users toward an unsupported API. Keep the command reference aligned with the released implementation while cloudflare/sandbox-sdk#357 remains unresolved.
thazhemadam
force-pushed
the
at/remove-stdin-stale-docs
branch
from
July 29, 2026 08:06
4c6ec9f to
dd4af7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts merge commit b56f39e.
Remove stale documentation claiming that
exec(),execStream(), andstartProcess()acceptstdininput. The documentation was added in cloudflare-docs#27850 to match cloudflare/sandbox-sdk#362, but the SDK change was closed without merging in favor of a future PTY-based design.The released SDK does not expose this option, so the current examples direct users toward an unsupported API. Keep the command reference aligned with the released implementation while
cloudflare/sandbox-sdk#357 remains unresolved.
Documentation checklist