[Load Balancing] Document regional health - #32373
Open
ncrouch-cflare wants to merge 1 commit into
Open
Conversation
Add a concept page for regional health, covering the reasons per-region health decisions exist, the local/regional/global health sources, how health_sources differs from check_regions, two worked examples, the recommended pool configuration, and when not to use the feature. Every behavioral claim is validated against the Load Balancing source tree (ctm-topology, ctm-director, ctm-health). The launch changelog entry is deliberately not included in this commit. It will land in a follow-up once the public launch date is confirmed. Validated locally: pnpm run check PASS (0 errors, 0 warnings) pnpm run build PASS (8732 pages) pnpm run lint PASS pnpm run format:core:check PASS
Contributor
Review
👉 Fix in your agent 👈Fix the following review findings in PR #32373 (https://github.com/cloudflare/cloudflare-docs/pull/32373).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Warnings (1)
#### CR-7752a6f895c2 · Inconsistent default health_sources behavior
- **File:** `src/content/docs/load-balancing/understand-basics/regional-health.mdx` line 61
- **Issue:** The doc first states that default behavior is a single global decision (line 19) and labels `global` as the default Load Balancing behavior (line 55). It then says an unset `health_sources` is equivalent to `["local", "global"]` (line 61). However, `local` applies only when `check_regions` is unset (line 53) and represents a per-data-center decision, not the global decision described earlier. The existing health-details page also notes that the All Data Centers case uses a majority-of-data-centers decision, which is still an aggregate, not a per-data-center `local` decision.
- **Fix:** Reconcile the default description. If unset truly preserves the existing single global/majority decision, state that explicitly and either remove `local` from the supported-sources table or clearly mark it as an internal-only fallback rather than a user-configurable source.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (1)
ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://1d765d7f.preview.developers.cloudflare.com Files with changes (up to 15) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a concept page for regional health, covering the reasons per-region health decisions exist, the local/regional/global health sources, how health_sources differs from check_regions, two worked examples, the recommended pool configuration, and when not to use the feature.
Every behavioral claim is validated against the Load Balancing source tree (ctm-topology, ctm-director, ctm-health).
The launch changelog entry is deliberately not included in this commit. It will land in a follow-up once the public launch date is confirmed.
Validated locally:
pnpm run check PASS (0 errors, 0 warnings)
pnpm run build PASS (8732 pages)
pnpm run lint PASS
pnpm run format:core:check PASS
Summary
Screenshots (optional)
Documentation checklist