Skip to content

[Load Balancing] Document regional health - #32373

Open
ncrouch-cflare wants to merge 1 commit into
productionfrom
docs/lb-regional-health
Open

[Load Balancing] Document regional health#32373
ncrouch-cflare wants to merge 1 commit into
productionfrom
docs/lb-regional-health

Conversation

@ncrouch-cflare

Copy link
Copy Markdown
Collaborator

Add a concept page for regional health, covering the reasons per-region health decisions exist, the local/regional/global health sources, how health_sources differs from check_regions, two worked examples, the recommended pool configuration, and when not to use the feature.

Every behavioral claim is validated against the Load Balancing source tree (ctm-topology, ctm-director, ctm-health).

The launch changelog entry is deliberately not included in this commit. It will land in a follow-up once the public launch date is confirmed.

Validated locally:
pnpm run check PASS (0 errors, 0 warnings)
pnpm run build PASS (8732 pages)
pnpm run lint PASS
pnpm run format:core:check PASS

Summary

Screenshots (optional)

Documentation checklist

  • Is there a changelog entry (guidelines)? If you don't add one for something awesome and new (however small) — how will our customers find out? Changelogs are automatically posted to RSS feeds, the Discord, and X.
  • The change adheres to the documentation style guide.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

Add a concept page for regional health, covering the reasons per-region
health decisions exist, the local/regional/global health sources, how
health_sources differs from check_regions, two worked examples, the
recommended pool configuration, and when not to use the feature.

Every behavioral claim is validated against the Load Balancing source
tree (ctm-topology, ctm-director, ctm-health).

The launch changelog entry is deliberately not included in this commit.
It will land in a follow-up once the public launch date is confirmed.

Validated locally:
  pnpm run check              PASS (0 errors, 0 warnings)
  pnpm run build              PASS (8732 pages)
  pnpm run lint               PASS
  pnpm run format:core:check  PASS
@ncrouch-cflare
ncrouch-cflare requested review from a team and elithrar as code owners July 28, 2026 18:38
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning found in commit 1d765d7.

👉 Fix in your agent 👈
Fix the following review findings in PR #32373 (https://github.com/cloudflare/cloudflare-docs/pull/32373).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Warnings (1)

#### CR-7752a6f895c2 · Inconsistent default health_sources behavior
- **File:** `src/content/docs/load-balancing/understand-basics/regional-health.mdx` line 61
- **Issue:** The doc first states that default behavior is a single global decision (line 19) and labels `global` as the default Load Balancing behavior (line 55). It then says an unset `health_sources` is equivalent to `["local", "global"]` (line 61). However, `local` applies only when `check_regions` is unset (line 53) and represents a per-data-center decision, not the global decision described earlier. The existing health-details page also notes that the All Data Centers case uses a majority-of-data-centers decision, which is still an aggregate, not a per-data-center `local` decision.
- **Fix:** Reconcile the default description. If unset truly preserves the existing single global/majority decision, state that explicitly and either remove `local` from the supported-sources table or clearly mark it as an internal-only fallback rather than a user-configurable source.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Warnings (1)
File Issue
load-balancing/understand-basics/regional-health.mdx line 61 Inconsistent default health_sources behavior — The doc first states that default behavior is a single global decision (line 19) and labels global as the default Load Balancing behavior (line 55). It then says an unset health_sources is equivalent to ["local", "global"] (line 61). However, local applies only when check_regions is unset (line 53) and represents a per-data-center decision, not the global decision described earlier. The existing health-details page also notes that the All Data Centers case uses a majority-of-data-centers decision, which is still an aggregate, not a per-data-center local decision. Fix: Reconcile the default description. If unset truly preserves the existing single global/majority decision, state that explicitly and either remove local from the supported-sources table or clearly mark it as an internal-only fallback rather than a user-configurable source.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@github-actions github-actions Bot added the product:load-balancing Related to Load Balancing product label Jul 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/load-balancing/ @cloudflare/cf1-reviewers, @elithrar, @cloudflare/product-owners, @ncrouch-cflare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:load-balancing Related to Load Balancing product size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants