Skip to content

fix: improve OneTrust cookie preferences modal accessibility - #32337

Open
diogoascarneiro wants to merge 4 commits into
productionfrom
feat/onetrust-styling
Open

fix: improve OneTrust cookie preferences modal accessibility#32337
diogoascarneiro wants to merge 4 commits into
productionfrom
feat/onetrust-styling

Conversation

@diogoascarneiro

Copy link
Copy Markdown
Contributor

Summary

Add focus management for OneTrust cookie preferences modal by automatically focusing the close button when the modal opens. Also import OneTrust-specific styles.

Screenshots (optional)

Documentation checklist

  • Is there a changelog entry (guidelines)? If you don't add one for something awesome and new (however small) — how will our customers find out? Changelogs are automatically posted to RSS feeds, the Discord, and X.
  • The change adheres to the documentation style guide.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

Add focus management for OneTrust cookie preferences modal by automatically focusing the close button when the modal opens. Also import OneTrust-specific styles.
@diogoascarneiro
diogoascarneiro requested review from a team and kodster28 as code owners July 27, 2026 15:37
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review

✅ No issues found in commit 48fae6b.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

No code review issues found.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
*.astro @cloudflare/content-engineering, @kodster28
*.ts @cloudflare/content-engineering, @kodster28
* @cloudflare/product-owners

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Update OneTrust cookie banner to show in preview and dev environments in addition to production. Improve button styling by using min-width instead of fixed width, allowing text wrapping, and adding underline to preference center button. Fix text alignment and focus state styling for better accessibility.
…ditionals

Move OneTrust focus management logic from inline script in BaseLayout to dedicated client script. Remove environment-based conditional rendering of OneTrust privacy choices link in Footer, making it always visible across all environments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants