fix(ai-chat): preserve first useAgentChat message during initial URL resolution#1541
Merged
threepointone merged 4 commits intoMay 19, 2026
Conversation
🦋 Changeset detectedLatest commit: 8677a96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
threepointone
approved these changes
May 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a mount-time race in
useAgentChatwhere a message sent immediately after first render could disappear from the hook'smessagesarray.Problem
When
useAgentChatmounts before the Agent HTTP URL is available:Chatinstance using a fallback chat ID.useAgentChatupgrades the chat ID to a URL-derived ID.Chatinstance, which drops the optimistic message state.Depending on timing, the first sent message would not remain visible in
messages.Fix
Keep the initial
ChatID stable across the HTTP URL transition for the same mounted Agent instance.The hook still recreates the chat when the consumer genuinely switches to a different Agent/chat, but it no longer recreates the chat just because the Agent URL becomes available after mount.
When initial persisted history resolves after an optimistic first send, late hydration now prepends missing hydrated messages instead of overwriting or discarding either side. Existing in-memory messages win by ID so newer local/stream state is not replaced by the fetch response.
Regression tests
Added React regression coverage for:
useAgentChatbeforegetHttpUrl()is readysendMessage()Validation
Passed:
npm run test:react --workspace packages/ai-chatnpx oxfmt --check packages/ai-chat/src/react.tsx packages/ai-chat/src/react-tests/use-agent-chat.test.tsxAlso ran
npm run check. Sherif, export validation, repository formatting, and Oxlint completed successfully; the typecheck stage could not execute in this local environment becausetsgowas unavailable (/bin/sh: tsgo: command not found).Release note
Includes a patch changeset for
@cloudflare/ai-chat.