Deprecating to Jakarta EE 8#732
Conversation
Signed-off-by: Jacek Bilski <jacek@bilski.tech>
Signed-off-by: Jacek Bilski <jacek@bilski.tech>
|
@Cali0707 My second PR is also almost ready. I did a lot of cleaning up there, Maven wrapper and plugins, documentation. I also upgraded things to their latest Jakarta EE 8-compatible versions, just to ease upgrading them to their Jakarta EE 9-compatible versions. It's just, more or less, bringing things in sync. As such, those changes might as well belong in here. Based on your proposed versioning, this could be version 4.1.1. Please take a look at jacekbilski#1. I could extend this PR with those changes if it would make sense to you. Because of that I also changed the title of this PR. I also started working on the next PR. The goal there would be moving to Java 17 and upgrading everything to Jakarta EE 9-compatible versions (Spring Boot 3, Quarkus 2, etc.). |
Cali0707
left a comment
Cali0707
left a comment
There was a problem hiding this comment.
Thanks for tackling this @jacekbilski !
Two small nits otherwise I am happy to go forwards with this change
| Documentation: https://cloudevents.github.io/sdk-java/http-jakarta-restful-ws | ||
| Documentation: https://cloudevents.github.io/sdk-java/http-jakarta-restful-ws-jakarta | ||
|
|
||
| The code for this package lies within the [restful-ws](https://github.com/cloudevents/sdk-java/tree/main/http/restful-ws) directory and is copied within here and has `javax.` replaced with `jakarta.` |
There was a problem hiding this comment.
@jacekbilski mind updating this bit? It is now outdated with your changes
There was a problem hiding this comment.
Fixed, I had it removed on at least one machine on which I was working on this.
| @@ -0,0 +1 @@ | |||
| io.cloudevents.http.restful.ws.CloudEventsProvider | |||
There was a problem hiding this comment.
I now deleted the file. It was saying that io.cloudevents.http.restful.ws.CloudEventsProvider implements jakarta.ws.rs.ext.Providers. But it does not, it never did.
|
@jacekbilski regarding your other PR, let's do those as a separate follow up. Additionally it looks like Kafka/Vertx have major version bumps there? Since those are exposed types in the public API that would be breaking changes so we should hold off on upgrading those two until we do the 5.0 set of changes. Otherwise that looks great and can be a 4.1.1 Thanks again for tackling all of this! |
Signed-off-by: Jacek Bilski <jacek@bilski.tech>
Signed-off-by: Jacek Bilski <jacek@bilski.tech>
…nt `jakarta.ws.rs.ext.Providers` - removing. Signed-off-by: Jacek Bilski <jacek@bilski.tech>
jacekbilski
force-pushed
the
jakarta_migration
branch
from
0a296d2 to
9bccefe
Compare
OK, as soon as this part is released I'll create a new PR.
OK, I'll do the upgrades later.
I always wanted to somehow contribute to open source, I finally got the chance. |
2 participants
As discussed in #705 and #729, see #729 (review), this is the first PR. The goal is to deprecate Jakarta EE 8 module and promote the Jakarta EE 9+ module.
I added Jakarta EE 9+ links in a few places where they were missing. I also fixed the links where they were still pointing to the Jakarta EE 8 module.
The examples are still using the now deprecated
cloudevents-http-restful-wsmodule. The reason is - I cannot upgrade Quarkus or Jetty simply because next major releases, that are Jakarta EE 9+-compatible would also require Java at least 11, but we're still on 8.