Fix enum dropdown showing a selection for unset fields - #928
Open
mihaelabalutoiu wants to merge 1 commit into
Open
Fix enum dropdown showing a selection for unset fields#928mihaelabalutoiu wants to merge 1 commit into
mihaelabalutoiu wants to merge 1 commit into
Conversation
Avoid matching an unset field value to an enum item with an undefined label. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enum fields with values but no
config_defaultcould show the first option as selected while the form value remainedunset, so the control displayed a value the form did not hold.This happened when an enum item had no
nameorlabel, producing anundefinedlabel that matched theunsetfield value.Skip the lookup when the field has no value, so only
config_defaultor an explicit user selection can select an option.