Fix C++ multi-column support for 3+ columns queries#5565
Draft
JasonAtClockwork wants to merge 1 commit into
Draft
Fix C++ multi-column support for 3+ columns queries#5565JasonAtClockwork wants to merge 1 commit into
JasonAtClockwork wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
A user reported a possible issue with ranged queries with multi-column indexes and during my investigation I found it was a deeper problem in how the original work handled situations with more than three columns.
API and ABI breaking changes
No intended breaking changes.
This change correctly rejects invalid usage such as
(exact, Range<>, exact), which was previously allowed but failed host-side.Expected complexity level and risk
3 - Changes to the internals of
IndexIteratorto handle iterator buffering is noteworthy but the public API should not be impacted.Testing