Dst bug: fix seqeuence migration precheck.#5561
Open
Shubham8287 wants to merge 1 commit into
Open
Conversation
Shubham8287
force-pushed
the
shub/sequence-precheck-fix
branch
from
July 17, 2026 10:26
fab0668 to
2a1bd3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
It fixes two bugs, both let
SequenceRangeValidmigration pre-check to pass incorrectly, which will causeUniqueConstraintVoilationerror:maxcalculation was buggied due to casting inAlgebraicValue::from_i128(u64::MAX as i64 == -1), it should be saturating conversion (Found by DST). It will resultingrangeto be formed asmin..-1causing non-effecting check.rangeforiter_by_col_range_mutexcludesmaxwhen it should be included.API and ABI breaking changes
NA
Expected complexity level and risk
Testing
Unit test.