Update #1717 to post .NET 10#5528
Draft
lisandroct wants to merge 6 commits into
Draft
Conversation
lisandroct
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
July 13, 2026 14:01
lisandroct
marked this pull request as draft
July 13, 2026 14:01
lisandroct
force-pushed
the
lisandro/update-1717
branch
from
July 17, 2026 13:54
3522943 to
7d8bc31
Compare
lisandroct
force-pushed
the
lisandro/update-1717
branch
from
July 17, 2026 19:33
7d8bc31 to
cde0a39
Compare
lisandroct
force-pushed
the
lisandro/update-1717
branch
from
July 17, 2026 19:49
cde0a39 to
75589f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Re-implements #1717 on top of latest
masterand .NET 10 support.It adds
IStructuralWritefor types that only need to be able to serialize themselves (in particular tagged enums). It cleans up things a little and models a real distinction between those types that can read and write themselves and those which can write only.That being said, it also adds complexity and we're currently working around the "lack of" a write method by accessing the
BSATN.Writemethods. In practice, this PR saves us from callingnew X.BSATN().Write(...).I'm not sure what the initial intent of Ingvar was and if this was preparing the grounds for something else. If all we'll achieve is avoid some calls to
BSATN.Write, I don't think I would move forward with this one.API and ABI breaking changes
No breaking changes.
Expected complexity level and risk
Testing