Skip to content

[NS 6] Migrations: handle mounted submodule tables, views, and indexes#5174

Open
aasoni wants to merge 1 commit into
alessandro/handle-module-mounts-in-clifrom
alessandro/handle-module-mounts-in-migrations
Open

[NS 6] Migrations: handle mounted submodule tables, views, and indexes#5174
aasoni wants to merge 1 commit into
alessandro/handle-module-mounts-in-clifrom
alessandro/handle-module-mounts-in-migrations

Conversation

@aasoni
Copy link
Copy Markdown
Contributor

@aasoni aasoni commented Jun 2, 2026

Description of Changes

Handle module migrations for modules that have mounted sub-modules. This required major surgery on the the migration step types which used "Identifier" which doesn't allow for dots or slashes.
It also required significant changes in the code that gathers and compares changes between the old and new module to correctly compare namespaced types with the corresponding mounted types.

API and ABI breaking changes

No

Expected complexity level and risk

4 - Significant change to migration code and logic. This shouldn't effect any logic for migrations that affect modules that don't have mounts, but the change is extensive enough that I think 4 is warrented.

Testing

Beyond the rust tests in the codebase that test various auto-migration cases for mounted modules I also did the following tests on sample module that had a mounted sub-module library:

  • Module migrates without issue from having a submodule to not having a submodule
  • Module migrates without issue from not having a submodule to having a submodule
  • Module migrates without issue when having a submodule and root module change occurs (change reducer signature, add table, add column with default, change reducer function body, change index)
  • Module migrates without issue when having a submodule and a submodule change occurs (change reducer signature, add table, add column with default, change reducer function body, change index)

@aasoni aasoni changed the title Migrations: handle mounted submodule tables, views, and indexes [NS 6] Migrations: handle mounted submodule tables, views, and indexes Jun 2, 2026
@aasoni aasoni force-pushed the alessandro/handle-module-mounts-in-cli branch from fe0654d to a284b57 Compare June 3, 2026 08:03
@aasoni aasoni force-pushed the alessandro/handle-module-mounts-in-migrations branch from 2dfc6d4 to be36425 Compare June 3, 2026 08:03
@aasoni aasoni force-pushed the alessandro/handle-module-mounts-in-cli branch from a284b57 to e54ed46 Compare June 3, 2026 12:22
@aasoni aasoni force-pushed the alessandro/handle-module-mounts-in-migrations branch from be36425 to 4fb542f Compare June 3, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant