[NS 2] flatten mounted module fields (tables/reducers/procedures/views) into the root module#5168
Open
aasoni wants to merge 1 commit into
Open
Conversation
a5dfaf5 to
c8cac1d
Compare
e7921b1 to
50ab365
Compare
50ab365 to
02954c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
For each mounted sub-module table and function we need to create them and make them accessible by the host. To do this they are "flattened" into the root module by creating a prefixed identifier (e.g. "<namespace>.<table name>").
API and ABI breaking changes
No
Expected complexity level and risk
3 - Complexity of the code change is manageable. Risk is not too high as the changes should only apply to sub-modules. Modules without submodules should be unaffected and handled by existing code.
Testing
The following testing was done for on the entire namespace feature (which is made of 5 PRs)
Module:
Client
CLI
Migration
Commit Log