durability: Use async-channel to allow blocking send#4802
Open
Conversation
The previous approaches would either: - panic when the queue becomes full, as `append_tx` is run inside the context of a `LocalSet`, which is basically a glorified current thread runtime - deadlock because the receiver runtime has no way of notifiying the sender of freed capacity in the channel `async-channel` handles wait queues and notifications internally, so can be used freely from either blocking or async contexts. This _may_ come at different performance characteristics, but I haven't measured them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous approaches would either:
append_txis run inside the context of aLocalSet, which is basically a glorified current thread runtimeasync-channelhandles wait queues and notifications internally, so can be used freely from either blocking or async contexts.This may come at different performance characteristics, but I haven't measured them.