[TS] Implement de/serialization as a tree of closures #3957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Requested @gefjon's review since they expressed familiarity with the strategy. |
coolreader18
force-pushed
the
noa/optimize-ts-serde
branch
5 times, most recently
from
16cef9f to
ed9c6bb
Compare
coolreader18
force-pushed
the
noa/optimize-ts-serde
branch
from
ed9c6bb to
03d3f82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This should optimize better than walking the AlgebraicType tree on every call. I'll do some profiling to confirm, but I am already using it in my performance experiments.
Expected complexity level and risk
2 - fully rewrites the bsatn encoder/decoder, but it's a fairly simple format.
Testing