Call parameterized views from sql: Execution#3933
Closed
Conversation
mamcx
added
the
Do not merge
mamcx
commented
Dec 27, 2025
|
|
||
| // Verify calling views with params | ||
| // TODO: All testing use the old query compiler, so we can't test this yet. | ||
| #[test] |
| Err(Unresolved::Literal.into()) | ||
| } | ||
| (SqlExpr::Lit(SqlLiteral::Str(v) | SqlLiteral::Num(v) | SqlLiteral::Hex(v)), Some(ty)) => Ok(Expr::Value( | ||
| (SqlExpr::Lit(SqlLiteral::Num(v)), Some(ty)) => { |
Contributor
Author
There was a problem hiding this comment.
Fix parsing for num-like literals
| ctx.db.player().chunk_index().filter(chunk_index) | ||
| }*/ | ||
|
|
||
| // ───────────────────────────────────────────────────────────────────────────── |
Contributor
Author
There was a problem hiding this comment.
Note we can't create yet view with params in modules?
mamcx
force-pushed
the
mamcx/sql-call-views-expr
branch
from
4c0a493 to
4289cd8
Compare
Contributor
|
This is substantially out of date. I'm going to close this and create an issue. |
cloutiertyler
added
the
close-stale-pr-create-issue
Collaborator
|
Closing this stale PR in favor of #4826, which tracks reimplementing the work on top of current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Second of a set PRs for closing of #3489.
Stacked against #3791
Expected complexity level and risk: 2
Need to change to passing
txmutable to allow for internal params creation.Testing
sqlstatements