Implement SpacetimeType for Result<T, E> #3790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
force-pushed
the
mamcx/result-type
branch
from
70ca89a to
4324cd7
Compare
Contributor
|
I'll build out an attached PR to add the new functionality for the Unreal SDK. |
mamcx
force-pushed
the
mamcx/result-type
branch
3 times, most recently
from
5a99c91 to
cf9dd2f
Compare
JasonAtClockwork
requested changes
Dec 17, 2025
Contributor
JasonAtClockwork
left a comment
JasonAtClockwork
left a comment
There was a problem hiding this comment.
There is updates to the /modules/sdk-test-cs but this won't be enough testing for the C# side. We'll need to add tests into the /sdks/csharp/examples~/regression-tests like for UUID to make sure this works end-to-end.
@rekhoff - I'll also want your eyes on this one when you can for the C# side
gefjon
approved these changes
Dec 18, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
I'm happy with the Rust parts of this PR. We'll still need review from the other languages' maintainers.
rekhoff
reviewed
Dec 18, 2025
rekhoff
approved these changes
Dec 18, 2025
coolreader18
approved these changes
Dec 19, 2025
Collaborator
coolreader18
left a comment
coolreader18
left a comment
There was a problem hiding this comment.
Seems reasonable to me, except for my one comment.
mamcx
force-pushed
the
mamcx/result-type
branch
3 times, most recently
from
604c452 to
c7b1f53
Compare
mamcx
force-pushed
the
mamcx/result-type
branch
2 times, most recently
from
32ebe84 to
bd8dba7
Compare
mamcx
force-pushed
the
mamcx/result-type
branch
from
bd8dba7 to
d5bd9e0
Compare
JasonAtClockwork
approved these changes
Dec 31, 2025
Contributor
JasonAtClockwork
left a comment
JasonAtClockwork
left a comment
There was a problem hiding this comment.
I've added a couple comments but otherwise this looks like a solid fix for tests on the C# side!
...examples~/regression-tests/client/module_bindings/Procedures/InsertWithTxRollbackResult.g.cs
Show resolved
Hide resolved
mamcx
force-pushed
the
mamcx/result-type
branch
from
a85626f to
370e005
Compare
mamcx
force-pushed
the
mamcx/result-type
branch
from
370e005 to
6898dc4
Compare
Signed-off-by: Ryan <r.ekhoff@clockworklabs.io>
Signed-off-by: Ryan <r.ekhoff@clockworklabs.io>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
# Description of Changes Closes #3673 *NOTE*: C++ part will be in another PR # Expected complexity level and risk 2 Adding a new type touch everywhere # Testing - [x] Adding smoke and unit test --------- Signed-off-by: Ryan <r.ekhoff@clockworklabs.io> Co-authored-by: rekhoff <r.ekhoff@clockworklabs.io> Co-authored-by: Phoebe Goldman <phoebe@goldman-tribe.org> Co-authored-by: Jason Larabie <jason@clockworklabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Closes #3673
NOTE: C++ part will be in another PR
Expected complexity level and risk
2
Adding a new type touch everywhere
Testing