fix(api): make HTTP response cache writes atomic#263
Open
baiyuxi930826 wants to merge 1 commit into
Open
Conversation
Write cache entries to a temp file in the same directory and rename into place so concurrent gh processes and mid-write crashes cannot leave a partial or interleaved cache file. Fixes cli#252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #252.
fileStorage.storeopened the final cache path withO_TRUNCand wrote the response in place. Concurrentghprocesses (mutex is in-process only) or a crash mid-write could leave a partial/corrupt cache entry.Change
Write to a same-directory temp file (
os.CreateTemp), thenos.Renameinto the final path. On Windows and Unix this is atomic within the same filesystem. Mode remains0600.Test plan
go test ./pkg/api/ -count=1