fix #97 Align process_schedule.input (VARCHAR(255) in the mapping) and log_record.process_execution_id (migration) - #98
Merged
Merged
Conversation
njoubert-cleverage
changed the title
…d log_record.process_execution_id ProcessSchedule::$input is mapped as VARCHAR(255), as created by the migrations (it was mapped as TEXT). log_record.process_execution_id was created as nullable (NOT NULL in the mapping): new migration deleting the log records without process execution before the NOT NULL change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
njoubert-cleverage
added a commit
that referenced
this pull request
Oct 5, 2026
process_execution.context was created as NOT NULL by Version20241007152613 while the mapping declares it nullable. Handled in Version20261005120000 (added by #98, never released). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #97.
process_schedule.input: the column created by the migrations (VARCHAR(255)) is kept, the mapping is fixed instead (the schedule input is a single-line value such as a file path):ProcessSchedule::$input:#[ORM\Column(length: 255, nullable: true)](wasTypes::TEXT)docs/reference/05-scheduler.md: 255 characters maxlog_record.process_execution_id: new migrationVersion20261005120000(MySQL / MariaDB, PostgreSQL; nothing on the other platforms, as the existing migrations):upDELETE FROM log_record WHERE process_execution_id IS NULL,MODIFY process_execution_id INT NOT NULLDELETE,ALTER process_execution_id SET NOT NULLdownMODIFY process_execution_id INT DEFAULT NULLALTER process_execution_id DROP NOT NULLThe log records without process execution are deleted before the
NOT NULLchange (they are never displayed: the UI lists the logs of an execution).Checked:
doctrine:migrations:migrateruns the 2 statements;process_schedule.inputandlog_record.process_execution_idno longer reported bydoctrine:schema:update --dump-sql(only the cosmetic(DC2Type:...)comments remain);down/upOKup/downrun, the orphan log record is deletedNot handled here: the migrations of the bundle are broken on PostgreSQL (#99).
Requirements
Breaking changes
None for the schemas created by the migrations. Applications that created
process_schedule.inputasTEXT(e.g. withdoctrine:schema:update) now get a diff toVARCHAR(255). The log records without process execution, if any, are deleted by the migration.🤖 Generated with Claude Code