Repository navigation
fix #91 Display the error message and keep the email after a failed login - #92
Merged
Merged
Conversation
…ame to the login template The EasyAdmin login template displays the error with the `error` variable and fills the email with `last_username`: after a failed login, no message was displayed and the email had to be typed again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #91.
LoginControllerinjectsAuthenticationUtilsand passeserror(getLastAuthenticationError()) andlast_username(getLastUsername()) to the login template, as expected by the EasyAdmin login template it extends. After a failed login, the page displays the error message (Invalid credentials.) and keeps the submitted email.SecurityTest::testLoginWithAnInvalidPasswordnow follows the redirection and asserts the.alert-dangermessage and the#usernamevalue.Checked:
testLoginWithAnInvalidPasswordfails. PHPStan, PHP-CS-Fixer, Rector OKInvalid credentials.displayed after an invalid password, email kept; a valid login still redirects to the UIRequirements
Breaking changes
None.
🤖 Generated with Claude Code