fix #99 Fix the migrations on PostgreSQL and document its support - #100
Merged
Merged
Conversation
1 of 3 tasks
No migration of the bundle could have run on PostgreSQL, so their PostgreSQL branches are fixed in place: - Version20231006111525: id columns created as identity columns (the sequences were not used as default value: inserts failed with the IDENTITY generation, the doctrine/orm 3 default) - Version20240729151928: process_schedule created with the PostgreSQL syntax (AUTO_INCREMENT failed) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
They only asserted the generated SQL, never executed on a database: they did not catch the PostgreSQL failures of #99. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #99.
No project runs the bundle on PostgreSQL: none of its migrations has been executed on PostgreSQL, so their PostgreSQL branches are fixed in place (no new migration):
Version20231006111525: the id columns oflog_record,process_executionandprocess_userare created as identity columns (id INT GENERATED BY DEFAULT AS IDENTITY, as generated by Doctrine). The standalone<table>_id_seqsequences were not used as default value: inserts without id (IDENTITY generation, the doctrine/orm 3 default) failed withnull value in column "id".Version20240729151928:process_schedulecreated with the PostgreSQL syntax (wasAUTO_INCREMENT: syntax error, the migrations stopped there).docs/index.mdmentions the supported databases (MySQL / MariaDB and PostgreSQL).process_execution.context(NOT NULLin the migrations, nullable in the mapping) is a mapping / schema difference, not a PostgreSQL issue (ADD ... NOT NULLworks on the empty table of a fresh installation): handled with #97.Tests of the migrations removed (
tests/Migrations/, separate commit): they only asserted the generated SQL, never executed on a database, and did not catch these PostgreSQL failures.Checked with the bundle migrations run by doctrine/migrations, then
SchemaTooland ORM inserts (doctrine/orm 3.7, DBAL 4.5):(DC2Type:...)column comments; ORM inserts ofUser,ProcessExecution,LogRecord,ProcessScheduleOK. Before this PR:syntax error at or near "AUTO_INCREMENT"downto the first migration thenup: OK, same schema, inserts OK(DC2Type:...)commentsmake startmigrations and fixtures, doctrine demo processes, UI login, launch from the UI consumed by the worker, schedule creationNot handled here: running the migrations on PostgreSQL / MySQL in the CI.
Requirements
Breaking changes
None: the PostgreSQL migrations failed, no project runs on PostgreSQL.
🤖 Generated with Claude Code