Skip to content

fix(task) #25 RequestTask fails the task when the SOAP call fails - #26

Merged
njoubert-cleverage merged 2 commits into
mainfrom
25
Sep 30, 2026
Merged

njoubert-cleverage merged 2 commits into
mainfrom
25

Conversation

@njoubert-cleverage

Copy link
Copy Markdown
Member

Description

Fixes #25.

When a SOAP call failed, RequestTask applied the error strategy itself: with stop, it stopped the process without setting an exception, so the process was not failed and the console command exited 0; with skip, the error outputs received false.

  • RequestTask::execute(): after logging the failed call (with the last request and response), throw a RuntimeException (Soap call '<method>' on client '<client>' failed), handled by the process manager like any other task error
  • RequestTaskTest (new): a successful call is output; a failed call throws without setting any output, error output or stopped flag (fails without the fix)
  • request_task.md, soap_enrich_csv.md cookbook: document the new behaviour

Checked in process-bundle-demo with a client pointing to a closed port:

  • demo.soap.call_failure (stop): the process fails, exit code 1 (executed successfully, exit code 0 before)
  • demo.soap.call_failure_skip (skip): the error outputs receive the task input (false before)

Requirements

  • Documentation updates
    • Reference
    • Cookbooks
    • Changelog
  • Unit tests

Breaking changes

  • With the stop strategy, a failed call now fails the process (non-zero exit code).
  • With the skip strategy, the error outputs receive the task input instead of false.

🤖 Generated with Claude Code

…s, so that the error strategy applies (the process fails with the stop strategy, the error outputs receive the task input with the skip strategy)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…sky tests when running with coverage

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@njoubert-cleverage
njoubert-cleverage merged commit b45ae00 into main Sep 30, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RequestTask: a failed SOAP call does not fail the process with the stop error strategy

1 participant