Repository navigation
fix(task) #25 RequestTask fails the task when the SOAP call fails - #26
Merged
Merged
Conversation
…s, so that the error strategy applies (the process fails with the stop strategy, the error outputs receive the task input with the skip strategy) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
3 tasks
…sky tests when running with coverage Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #25.
When a SOAP call failed,
RequestTaskapplied the error strategy itself: withstop, it stopped the process without setting an exception, so the process was not failed and the console command exited 0; withskip, the error outputs receivedfalse.RequestTask::execute(): after logging the failed call (with the last request and response), throw aRuntimeException(Soap call '<method>' on client '<client>' failed), handled by the process manager like any other task errorRequestTaskTest(new): a successful call is output; a failed call throws without setting any output, error output or stopped flag (fails without the fix)request_task.md,soap_enrich_csv.mdcookbook: document the new behaviourChecked in process-bundle-demo with a client pointing to a closed port:
demo.soap.call_failure(stop): the process fails, exit code 1 (executed successfully, exit code 0 before)demo.soap.call_failure_skip(skip): the error outputs receive the task input (falsebefore)Requirements
Breaking changes
stopstrategy, a failed call now fails the process (non-zero exit code).skipstrategy, the error outputs receive the task input instead offalse.🤖 Generated with Claude Code