cleverage/soap-process-bundle#29 to #33 - Add demo processes with a mocked SOAP service, #68 fix the oorsprong client features - #69
Merged
Conversation
…OAP service mocked by WireMock; #68 Fix the features option of the oorsprong_countryinfo client Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #68.
Demo processes reproducing soap bundle bugs, fixed by cleverage/soap-process-bundle#34, with a SOAP service mocked by WireMock (no network access):
.docker/wiremock/mappings/soap-*.json:GetBook,IsAvailable(returnsfalse) andFail(SOAP fault) methods, in non-WSDL mode (urn:demo, matched on theSOAPActionheader)config/services.yaml:wiremockSOAP client (sets aClientTokenheader withcalls: [setSoapHeaders, ...]) andwiremock_no_exceptions(exceptions: false)demo.soap.client_headers: RequestTask overwrites the SOAP options and headers of the client definition soap-process-bundle#29 (headers of the client definition overwritten), checked by counting the requests with the WireMock admin APIdemo.soap.headers_leak: SOAP options and headers of a RequestTask leak to the next calls of the client soap-process-bundle#30 (task headers leaking to thesoap_requesttransformer)demo.soap.false_result: A SOAP method returning false is handled as a failed call soap-process-bundle#31 (falseresult handled as failed)demo.soap.fault_without_exceptions: SOAP faults are output as results with the exceptions: false option soap-process-bundle#32 (SoapFaultoutput withexceptions: false)demo.soap.invalid_input: RequestTask fails with an unrelated TypeError on a non-array input soap-process-bundle#33 (TypeErroron a string input)docs/wiremock.md: mocking a SOAP service#68 (audit point #42): the
features: SOAP_SINGLE_ELEMENT_ARRAYSoption of theoorsprong_countryinfoclient is moved fromsetSoapOptions()(__soapCall()options, where it had no effect) to theSoapClientconstructor options, with!php/const.demo.soapstill runs successfully, with the current and the fixed bundle.With the fix, the processes show the corrected behaviour; on the current bundle
main, they reproduce the bugs described in the issues. Merge after the bundle PR is merged and the bundle is updated in this project.Requirements
Breaking changes
None (new demo processes, stubs and clients; demo client configuration fix).
🤖 Generated with Claude Code