chore(tests) #38 Add missing tests - #39
Merged
Merged
Conversation
…rineQueryTask query builder, readers, bundle and DI extension Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #38.
Completes the tests added with #30 and #32 to #36:
DatabaseUpdaterTaskSqliteTest(new):DatabaseUpdaterTaskon an in-memory SQLite database, with the real options resolution (the existing tests overridegetOptions()/getConnection()). It coversinput_as_paramsby default, theparamsoption with anArrayParameterType, the number of affected rows (0 included), non-array input,sqlrequired, invalid option type, and theconnectionoption.DatabaseReaderTaskSqliteTest:next()before the first execution,connectionoptionDoctrineReaderTaskTest:next()before the first executionAbstractDoctrineQueryTaskTest: generated DQL and parameters for=,IS nullandINcriteria,order_by(ASCby default for anullorder),limit/offset; query without criteriaCleverAgeDoctrineProcessExtensionTest(new): the 10 tasks registered as non-shared services in thecleverage_process_tasklogger channel, with a public alias on their class (used as@<class>in process configurations), and no untested task serviceCleverAgeDoctrineProcessBundleTest(new):getPath()is the bundle rootCoverage: 286/286 lines (78 tests, 259/286 before).
The 2 PHPUnit deprecations come from
phpunit.xml.dist(executionOrder="depends", schema), not from the tests: out of the scope of this PR.Requirements
Breaking changes
None (tests only).
🤖 Generated with Claude Code