fix(task) #30 DatabaseReaderTask no longer drops rows with the paginate option - #31
Merged
Merged
Conversation
…ch full page with the paginate option Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #30.
With the
paginateoption,DatabaseReaderTaskfetched one row beyond each full page and never output it. The pagination loop now stops fetching as soon as the page is full, so every row is output exactly once.DatabaseReaderTask::execute(): the page starts with the current row, and rows are fetched only while the page is not fullDatabaseReaderTaskTest::testExecuteWithPaginationDoesNotLoseRows: 3 rows read by pages of 2 give[row1, row2]then[row3](fails without the fix)database_reader_task.md: remove the note about the lost rowsChecked with
demo.doctrine.database.read_paginatein process-bundle-demo (3 books, pages of 2):"89,90"then"91"(only"89,90"before).Requirements
Breaking changes
None.
🤖 Generated with Claude Code