Repository navigation
feat(electron): add passkey support #8850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jeremy-clerk
merged 9 commits into
jw/electron-package-scaffold
from
jw/electron-sdk-passkey-support
Jun 17, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b3f954e
feat(electron): add passkey support
jeremy-clerk 8eb828f
docs(electron): document passkey setup
jeremy-clerk d3aa258
feat(electron): add passkey support
jeremy-clerk fbe3716
feat(electron): Report SDK version to FAPI via query param (#8847)
jeremy-clerk b1f8ee6
chore: dedupe
wobsoriano 8661651
chore(repo): enable electron passkeys workflow
jeremy-clerk 7f9bf6c
chore(repo): remove electron passkeys changeset
jeremy-clerk 5fe3aaf
chore(repo): refine electron passkeys workflow
jeremy-clerk 7b3ae46
chore(electron-passkeys): add temporary native bindings
wobsoriano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| name: Electron Passkeys Native Build | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| paths: | ||
| - 'packages/electron-passkeys/**' | ||
| - '.github/workflows/electron-passkeys.yml' | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build ${{ matrix.settings.target }} | ||
| runs-on: ${{ matrix.settings.host }} | ||
| timeout-minutes: 30 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| settings: | ||
| - host: macos-14 | ||
| target: aarch64-apple-darwin | ||
| - host: macos-14 | ||
| target: x86_64-apple-darwin | ||
| - host: windows-latest | ||
| target: x86_64-pc-windows-msvc | ||
| - host: windows-latest | ||
| target: aarch64-pc-windows-msvc | ||
| defaults: | ||
| run: | ||
| working-directory: packages/electron-passkeys | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 24 | ||
|
|
||
| - uses: pnpm/action-setup@v4 | ||
|
|
||
| - uses: dtolnay/rust-toolchain@stable | ||
| with: | ||
| targets: ${{ matrix.settings.target }} | ||
|
|
||
| - uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| workspaces: packages/electron-passkeys | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install --filter @clerk/electron-passkeys... --frozen-lockfile --ignore-scripts | ||
| working-directory: . | ||
|
|
||
| - name: Build native module | ||
| run: pnpm build --target ${{ matrix.settings.target }} | ||
|
|
||
| - name: Smoke test (host-native targets only) | ||
| if: matrix.settings.target == 'aarch64-apple-darwin' || matrix.settings.target == 'x86_64-pc-windows-msvc' | ||
| run: node -e "const m = require('./index.js'); console.log('isAvailable:', m.isAvailable(), 'capabilities:', JSON.stringify(m.capabilities())); if (!m.isAvailable()) throw new Error('the loader did not find the freshly built native binary');" | ||
|
|
||
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: bindings-${{ matrix.settings.target }} | ||
| path: packages/electron-passkeys/electron-passkeys.*.node | ||
| if-no-files-found: error | ||
|
|
||
| package: | ||
| name: Assemble platform packages | ||
| needs: build | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| defaults: | ||
| run: | ||
| working-directory: packages/electron-passkeys | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 24 | ||
|
|
||
| - uses: pnpm/action-setup@v4 | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install --filter @clerk/electron-passkeys... --frozen-lockfile --ignore-scripts | ||
| working-directory: . | ||
|
|
||
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| path: packages/electron-passkeys/artifacts | ||
|
|
||
| - name: Move binaries into per-platform npm packages | ||
| run: pnpm artifacts | ||
|
|
||
| - name: Verify every platform package contains its binary | ||
| run: | | ||
| for dir in npm/*/; do | ||
| count=$(find "$dir" -name '*.node' | wc -l) | ||
| if [ "$count" -ne 1 ]; then | ||
| echo "::error::$dir is missing its .node binary — publishing it would ship an empty package" | ||
| exit 1 | ||
| fi | ||
| (cd "$dir" && npm pack --dry-run) | ||
| done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| target/ | ||
| *.node | ||
| artifacts/ | ||
| # napi-generated type defs for the raw native binding (the public surface is | ||
| # the hand-written index.js/index.d.ts loader) | ||
| native.d.ts |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saved as .template so we don't run this action yet