Skip to content

Conversation

@dstaley
Copy link
Member

@dstaley dstaley commented Feb 12, 2026

Description

This PR fixes an issue where captchas were always called during sign-up with the new APIs. They are now conditionally called based on the same RHC and bypass logic currently used in the existing APIs.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where captcha was being called unnecessarily during the signup process.
    • Captcha bypass logic now respects configured strategy and context settings.
  • Tests

    • Extended test coverage for captcha bypass scenarios.

@vercel
Copy link

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Feb 12, 2026 8:49pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2026

🦋 Changeset detected

Latest commit: 893780e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 12, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7835

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7835

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7835

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7835

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7835

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7835

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7835

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7835

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7835

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7835

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@7835

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7835

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7835

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7835

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7835

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7835

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7835

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7835

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7835

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7835

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7835

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7835

commit: 893780e

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 12, 2026

📝 Walkthrough

Walkthrough

The changes introduce a captcha bypass mechanism in the SignUp resource. A new private helper method shouldBypassCaptchaForAttempt evaluates whether to skip captcha based on strategy and transfer parameters using the environment's displayConfig. The getCaptchaToken method is refactored to accept optional parameters and early-return when bypass conditions are met. Calls to getCaptchaToken throughout the file are updated to pass strategy context. Test coverage is extended to verify captcha invocation behavior under various bypass conditions and OAuth strategies.

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (5 files):

⚔️ packages/clerk-js/src/core/resources/PublicUserData.ts (content)
⚔️ packages/clerk-js/src/core/resources/SignUp.ts (content)
⚔️ packages/clerk-js/src/core/resources/__tests__/PublicUserData.test.ts (content)
⚔️ packages/clerk-js/src/core/resources/__tests__/SignUp.test.ts (content)
⚔️ packages/shared/src/types/json.ts (content)

These conflicts must be resolved before merging into main.
Resolve conflicts locally and push changes to this branch.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: making captcha invocation conditional during sign-up rather than always calling it.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant