Skip to content

Conversation

@jacekradko
Copy link
Member

@jacekradko jacekradko commented Feb 12, 2026

Summary

  • Export the Appearance type from packages/shared/src/ui/types.ts so it is included in @clerk/shared/types
  • A codemod migrating imports from @clerk/types to @clerk/shared/types produces import type { Appearance } from "@clerk/shared/types", which fails because the type was declared without the export keyword
  • Adding export to the existing type Appearance = any declaration makes it available through the barrel re-export in packages/shared/src/types/index.ts
   Creating an optimized production build ...
 ✓ Compiled successfully in 1987.4ms
   Running TypeScript  .Failed to compile.

./app/layout.tsx:2:15
Type error: Module '"@clerk/shared/types"' has no exported member 'Appearance'.

  1 | import { ClerkProvider } from "@clerk/nextjs";
> 2 | import type { Appearance } from "@clerk/shared/types";
    |               ^
  3 | import "./globals.css";
  4 | import Script from "next/script";
  5 | import localFont from "next/font/local";
Next.js build worker exited with code: 1 and signal: null

Test plan

  • pnpm build --filter @clerk/shared passes
  • Appearance appears in the export list of packages/shared/dist/types/index.d.ts
  • Only the intended file is modified (packages/shared/src/ui/types.ts)

Summary by CodeRabbit

  • Chores
    • Made the Appearance type publicly available for external use in integrations and extensions.
    • Added a changeset entry to mark this update for a patch release.

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2026

🦋 Changeset detected

Latest commit: 453830e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@clerk/shared Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/chrome-extension Patch
@clerk/clerk-js Patch
@clerk/expo-passkeys Patch
@clerk/expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/msw Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/react Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Feb 12, 2026 8:40pm

Request Review

@@ -2,7 +2,7 @@ import type { ModuleManager } from '../moduleManager';
import type { Clerk, ClerkOptions, EnvironmentResource } from '../types';

// TODO @nikos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, whats todo?

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 12, 2026

📝 Walkthrough

Walkthrough

The Appearance type in packages/shared/src/ui/types.ts was changed from a non-exported declaration to export type Appearance = any;, making the type publicly exported. A changeset file was added documenting this API export and indicating a patch release. No other code, behavior, or type contents were modified.

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (4 files):

⚔️ packages/clerk-js/src/core/resources/PublicUserData.ts (content)
⚔️ packages/clerk-js/src/core/resources/__tests__/PublicUserData.test.ts (content)
⚔️ packages/shared/src/types/json.ts (content)
⚔️ packages/shared/src/ui/types.ts (content)

These conflicts must be resolved before merging into main.
Resolve conflicts locally and push changes to this branch.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(shared): export Appearance type from ui/types' clearly and concisely summarizes the main change: exporting the Appearance type from the ui/types module in the shared package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 12, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7833

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7833

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7833

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7833

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7833

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7833

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7833

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7833

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7833

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7833

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@7833

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7833

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7833

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7833

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7833

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7833

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7833

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7833

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7833

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7833

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7833

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7833

commit: 453830e

@jacekradko jacekradko closed this Feb 13, 2026
@jacekradko jacekradko deleted the jacek/export-appearance-type branch February 13, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants