-
Notifications
You must be signed in to change notification settings - Fork 436
fix(shared): export Appearance type from ui/types #7833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 453830e The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| @@ -2,7 +2,7 @@ import type { ModuleManager } from '../moduleManager'; | |||
| import type { Clerk, ClerkOptions, EnvironmentResource } from '../types'; | |||
|
|
|||
| // TODO @nikos | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol, whats todo?
📝 WalkthroughWalkthroughThe 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Summary
Appearancetype frompackages/shared/src/ui/types.tsso it is included in@clerk/shared/types@clerk/typesto@clerk/shared/typesproducesimport type { Appearance } from "@clerk/shared/types", which fails because the type was declared without theexportkeywordexportto the existingtype Appearance = anydeclaration makes it available through the barrel re-export inpackages/shared/src/types/index.tsTest plan
pnpm build --filter @clerk/sharedpassesAppearanceappears in the export list ofpackages/shared/dist/types/index.d.tspackages/shared/src/ui/types.ts)Summary by CodeRabbit