Repository navigation
refactor(expo): extract shared FAPI request helpers and app identifier lookup - #10832
wobsoriano wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: ab2bb07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |



Description
Session transfer in #10767 needs the same FAPI response handling that hosted auth already does. Hosted auth keeps it private in
utils/hostedAuth.ts, along with the app identifier lookup inuseHostedAuth. Session transfer would have to copy both.This PR moves that code into two shared modules, with no change to hosted auth.
utils/fapiRequest.tshas the response helpers. They turn an error response into aClerkAPIResponseErrorwith itsstatus, errors, andRetry-After, check the responseobjecttype, and retry once after asigned_out401.utils/appIdentifier.tshasgetExpoAppIdentifier, which reads the iOS bundle identifier or Android package from the app config.Hosted auth now imports both. The requests it sends, the errors it throws, and its retry are the same as before. #10767 is the second user, and #10825 is stacked on it.
There is no changelog entry, because nothing changes for apps.
The existing hosted auth tests pass unchanged. I have not rerun hosted auth on a simulator or emulator for this PR.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
🤖 Generated with Claude under Rob's supervision.
Part of MOBILE-450