fix: write .claude.json to ~/.claude/ instead of homedir root - #1336
Open
p2p3p wants to merge 1 commit into
Open
fix: write .claude.json to ~/.claude/ instead of homedir root#1336p2p3p wants to merge 1 commit into
p2p3p wants to merge 1 commit into
Conversation
Contributor
📝 WalkthroughWalkthrough
ChangesConfiguration directory resolution
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/utils/env.ts`:
- Around line 25-28: Update getClaudeConfigHomeDir in envUtils.ts to treat an
empty CLAUDE_CONFIG_DIR as unset, while preserving its existing
configured-directory behavior; then update the path construction in the shown
utility to use getClaudeConfigHomeDir as the sole source of the base directory.
Add a regression test covering CLAUDE_CONFIG_DIR="" and verify the resulting
path remains under the default Claude configuration directory rather than
becoming relative.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
将 .claude.json 写入路径从 homedir() 根目录改为 getClaudeConfigHomeDir() 对应的 ~/.claude/ 目录。
Summary by CodeRabbit