fix(create): ensure CKB binary and devnet config before generating scripts#419
Merged
fix(create): ensure CKB binary and devnet config before generating scripts#419
Conversation
…ripts Fix issue #396 where offckb create fails if user hasn't run offckb node first. Changes: - Add imports for installCKBBinary, initChainIfNeeded, readSettings - Call installCKBBinary to download CKB binary if not exists - Call initChainIfNeeded to initialize devnet config if not exists - Both calls happen before genSystemScriptsJsonFile to ensure dependencies are ready This makes offckb create self-sufficient and doesn't require prior offckb node execution.
|
✅ Changeset file detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #396
Problem
offckb createfailed when user hasn't runoffckb nodefirst because:Both are required by
genSystemScriptsJsonFilewhich executesckb list-hashes.Solution
Add pre-installation checks in
create.ts:installCKBBinary,initChainIfNeeded, andreadSettingsinstallCKBBinaryto download CKB binary if not existsinitChainIfNeededto initialize devnet config if not existsgenSystemScriptsJsonFileChanges
src/cmd/create.ts: +3 lines (imports and function calls)Testing
Verification