Write product comparison reports as UTF-8 - #712
Merged
willhea merged 4 commits intoAug 26, 2026
Conversation
Use explicit UTF-8 at both product report output boundaries. Refs civictechdc#627 Co-Authored-By: GPT-5.6 Luna <noreply@openai.com>
Cover both builtins.open and io.open while preserving unrelated writes. Co-Authored-By: GPT-5.6 Luna <noreply@openai.com>
Associate only exact-output descriptors with the simulated default encoding and verify unrelated descriptors stay untouched. Co-Authored-By: GPT-5.6 Luna <noreply@openai.com>
Replace stateful descriptor simulation with a verified locale boundary that runs each real CLI route and reports setup, encoding, and byte outcomes distinctly. Co-Authored-By: GPT-5.6 Luna <noreply@openai.com>
Collaborator
|
Looks great, thanks @Nitjsefnie! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Refs #627
What does this change?
Makes the XML and PDF product report writers use explicit UTF-8 so comparison output containing Unicode markers can be saved independently of the host's default text encoding.
→and⚠.How to test
0f94e3aba052d0ed4976da0767475d2a16742e8f.closefd=Falselifecycles and through byte-spelled paths. Each failed only its corresponding behavior assertion underANSI_X3.4-1968; the sibling route passed: 32807070688, 32807148081, 32807219847, 32807291945.0f94e3aba052d0ed4976da0767475d2a16742e8f.SHIP 0f94e3aba052d0ed4976da0767475d2a16742e8f.Checklist
Closes #...)AI assistance
GPT-5.6 Luna implemented and tested the change. GPT-5.6 Sol independently reviewed and verified it.
Generated by GPT-5.6 Luna (implementation, testing), GPT-5.6 Sol (brief, review, verification)