Bump tools pin to v0.8.39 in release workflows - #1224
Open
ibrahim halatci (ihalatci) wants to merge 1 commit into
Open
Bump tools pin to v0.8.39 in release workflows#1224ibrahim halatci (ihalatci) wants to merge 1 commit into
ibrahim halatci (ihalatci) wants to merge 1 commit into
Conversation
build-package.yml and update_package_properties.yml still cloned tools
v0.8.36, while build-citus-community-nightlies.yml was already on
v0.8.39. Align all three.
v0.8.36 has a bug in citus_package.py get_postgres_versions(): the
nightly exclusion filter iterated release_versions instead of
nightly_versions, so nightly versions were rebuilt from the
already-release-filtered list. This became reachable once pg_exclude.yml
gained a non-empty nightly block (nightly: all: [19]) - previously
nightly: {} was falsy and the block never ran.
Between v0.8.36 and v0.8.39 the scripts these two workflows invoke
change only additively:
- citus_package.py: adds ubuntu,resolute mapping; fixes the nightly
filter; includes build stdout+stderr in the failure exception
- upload_to_package_cloud.py: adds ubuntu/resolute distro id
- common_tool_methods.py: adds resolute to the ubuntu release list
update_package_properties.py itself is unchanged between the two tags.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 1ed7b58a-0ba9-4f47-a1de-3ee665bae7f2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the
citusdata/toolspin fromv0.8.36tov0.8.39in the tworelease workflows that were left behind:
build-package.ymlv0.8.36v0.8.39update_package_properties.ymlv0.8.36v0.8.39build-citus-community-nightlies.ymlv0.8.39Diff is exactly +2/-2 (one line per file). All three
all-citusworkflows now agree on
v0.8.39.Why
v0.8.36carries a bug incitus_package.py::get_postgres_versions()—the nightly exclusion filter iterated
release_versionsinstead ofnightly_versions, so the nightly list was rebuilt from thealready-release-filtered list:
Fixed in
v0.8.39(tools #423).This was dormant while
pg_exclude.ymlhadnightly: {}— an empty dictis falsy, so the block never executed. It became reachable on this branch
once
pg_exclude.ymlgained a non-emptynightly:section:all-citusis the only branch carrying apg_exclude.yml, so it is theonly branch where this bug is reachable.
develop,debian-hllanddebian-topnhave no exclusion file and are intentionally untouched here.Nothing is broken today, because the workflow that actually consumes
nightly versions (
build-citus-community-nightlies.yml) was alreadypinned to
v0.8.39. This closes the gap so correctness no longer dependson which workflow happens to run.
Upgrade risk
v0.8.36...v0.8.39is 7 commits. Restricted to the scripts these twoworkflows invoke, every change is additive:
citus_package.py— adds theubuntu,resoluteplatform mapping, fixesthe nightly filter above, and includes build
stdout+stderrin thefailure exception instead of
stderraloneupload_to_package_cloud.py— adds theubuntu/resolutedistro idcommon_tool_methods.py— addsresoluteto the ubuntu release listupdate_package_properties.pyis unchanged between the two tags.The Docker-template changes in that range (including the removed
postgres-14/postgres-15templates) are driven byupdate_docker.pyand
publish_docker.py, neither of which is invoked by these workflows.Validation
yaml.safe_load; job keys unchanged(
build_package,trigger_package_tests,update_package_properties)--depth=1is preserved byte-for-bytegit diff --statconfirms 2 files changed, 2 insertions, 2 deletionsConflicts
No overlap with #1220, which edits the arm64 debsigner build context at
line 98 of the same file. This PR touches line 64. The two merge cleanly
in either order.