Phase 6A: remove retained PAT shadow (all-citus)#1194
Open
ihalatci wants to merge 1 commit into
Open
Conversation
Every token-consuming job on all-citus already mints its own GitHub App
token (actions/create-github-app-token@v3) and exports GH_TOKEN/GITHUB_TOKEN
to $GITHUB_ENV, so the retained top-level env: PAT shadow lines
(GH_TOKEN/GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}) are unused. Remove them
from build-package.yml (both), build-citus-community-nightlies.yml, and
update_package_properties.yml. No job references secrets.GH_TOKEN anymore.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 6A: remove retained PAT shadow (all-citus)
all-citusis already fully migrated to the GitHub App token (PR #1189, merged). Every token-consuming job in these workflows already mints its own token viaactions/create-github-app-token@v3and exportsGH_TOKEN/GITHUB_TOKENto$GITHUB_ENV. The only remaining reference to the org PAT was the retained top-levelenv:shadow lines, kept for rollback. This PR removes them — proving the branch runs on the App token alone (Phase 6B readiness).Change: pure 4-line delete (0 additions)
GH_TOKEN: ${{ secrets.GH_TOKEN }}andGITHUB_TOKEN: ${{ secrets.GH_TOKEN }}(2 lines).GH_TOKEN: ${{ secrets.GH_TOKEN }}(1 line).GH_TOKEN: ${{ secrets.GH_TOKEN }}(1 line).No other lines touched: no changes to
steps.app-token,$GITHUB_ENVexports,--gh_token, pins, matrices, or runners. After this delete,secrets.GH_TOKENno longer appears anywhere in these files, and noenv:block was emptied (each retains its other keys such asMAIN_BRANCH/PRJ_NAME).Validation — both push-triggered workflows GREEN on head
52c3a1fupdate_package_properties.ymlisworkflow_dispatch-only, so it does not auto-fire on push and was intentionally NOT dispatched (it has real side effects — a package-properties bump PR). Structural parity is accepted against the already-green all-citus dispatch run 28507931145.⚠ MERGE HELD
Opening for review only — do not merge / no auto-merge until the user gives explicit merge approval.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com