Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gen-sdk.shimmediately when a generation, transformation, lint, or formatting command fails.Problem / root cause
The script previously returned the status of its last command. In an isolated fixture on current
master, generator exit 23 and transform exit 29 both resulted in overall exit 0, and lint/format still ran. A failed transform also replaced the generatedindex.tswith an empty file.set -epropagates these failures and prevents the subsequentmvafter a failed transform. This does not add transactional rollback or change generated SDK APIs.Testing
tests/gen-sdk.test.ts; focused strict TypeScript checking also passed. This is not a claim that the repository's pinned Jest 28 / ts-jest suite ran.Risk / compatibility
Only the documented developer codegen command changes failure handling. The successful command order is unchanged. A failing generator can still leave a partial generated tree; atomic preservation is intentionally out of scope.
AI assistance was used to investigate, implement and validate this change.