Skip to content

fix(malachite-app): harden response capacity check with safe arithmetic in GetDecidedValues #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
forumevi wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −7
Open

fix(malachite-app): harden response capacity check with safe arithmetic in GetDecidedValues #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions crates/malachite-app/src/handlers/get_decided_values.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,13 +157,12 @@ async fn get_decided_values(
//
// Moreover, Malachite will perform a very similar over-approximation when checking
// the response to GetDecidedValues, so this keeps our behavior consistent.
#[allow(clippy::arithmetic_side_effects)]
// Equivalent to `total_bytes + raw_bytes_len > max_response_size`,
// but rearranged so the subtraction cannot overflow (raw_bytes_len <= max_response_size
// is checked first, and max_response_size.0 - raw_bytes_len.0 is then non-negative).
if raw_bytes_len > max_response_size
|| total_bytes.as_u64() > max_response_size.as_u64() - raw_bytes_len.as_u64()
{
let is_exceeded = max_response_size
.as_u64()
.checked_sub(raw_bytes_len.as_u64())
.map_or(true, |remaining_capacity| total_bytes.as_u64() > remaining_capacity);

if is_exceeded {
warn!(
%height, %max_response_size, %raw_bytes_len,
"GetDecidedValues: Reached max total bytes limit for response, stopping here",
Expand Down