fix(genesis): normalize genesis identity comparisons - #374
Open
pawansatoshi wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize hexadecimal identities at comparison boundaries during genesis validation.
schemaAddressandschemaHexaccept mixed-case hexadecimal values, but several genesis validation checks previously compared raw strings. Because hexadecimal casing does not change the represented bytes, equivalent identities with different casing could bypass uniqueness or role-separation checks.What changed
Regression coverage
Added tests covering:
Security impact
This is a genesis/configuration integrity issue rather than a standalone permissionless exploit.
Without normalization, a malformed genesis configuration could represent the same underlying address/key bytes multiple times while bypassing string-based uniqueness or role-separation checks. This could result in unintended duplicate identities or role assignments during genesis construction.
The fix makes comparisons operate on the represented hexadecimal identity rather than its textual casing.
Validation
The regression tests are included in:
tests/unit/validator-manager-genesis-validation.test.tsThe full Arc toolchain was not executed in this environment. Before merging, run the repository's normal validation commands, including:
make test-unit-hardhatmake lintand attach/verify the resulting CI checks.
Scope
This PR is intentionally limited to genesis identity normalization and its regression coverage. EIP-7702 transaction-pool research was kept separate from this PR.