Potential fix for code scanning alert no. 44: Server-side request forgery#3
Draft
cindiekinzz-coder wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 44: Server-side request forgery#3cindiekinzz-coder wants to merge 1 commit into
cindiekinzz-coder wants to merge 1 commit into
Conversation
…gery Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/cindiekinzz-coder/NESTstack/security/code-scanning/44
General fix: never concatenate user-controlled full URLs (or raw request URLs) into outbound request targets. Instead, construct the target with
new URL()from a trusted base URL, and append only validated route/path/query components.Best fix here (without changing intended functionality): in the
/v1/{*path}proxy block, replaceconst target = \${openclawUrl}${req.originalUrl}`;` with URL-safe construction:req.params.path(route-captured wildcard) instead ofreq.originalUrl.new URL(base)and setpathnameandsearchexplicitly.This change is in NESTdesktop/local-agent.js, around lines 440–445.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.