Convert to multi-module structure - #11
Open
Manvi-55 wants to merge 4 commits into
Open
Conversation
Manvi-55
commented
Jul 14, 2026
Manvi-55
commented
Contributor
- Move source code and build files into cics-java-liberty-springboot-security-app module
- Add cics-java-liberty-springboot-security-cicsbundle module for CICS bundle packaging
- Update root pom.xml to parent POM with module declarations
- Update settings.gradle to include both subprojects
- Both Gradle and Maven builds verified successful
- Move source code and build files into cics-java-liberty-springboot-security-app module - Add cics-java-liberty-springboot-security-cicsbundle module for CICS bundle packaging - Update root pom.xml to parent POM with module declarations - Update settings.gradle to include both subprojects - Update .gitignore to exclude build/target directories in all modules - Both Gradle and Maven builds verified successful
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ayushikumari3
force-pushed
the
manvi/samples
branch
from
July 23, 2026 10:26
2dc92c9 to
fa804aa
Compare
| <faceted-project> | ||
| <fixed facet="jst.java"/> | ||
| <fixed facet="jst.web"/> | ||
| <installed facet="jst.web" version="2.4"/> |
Contributor
There was a problem hiding this comment.
facet version should be 6.0 to match servlet-6.0
| <fixed facet="jst.java"/> | ||
| <fixed facet="jst.web"/> | ||
| <installed facet="jst.web" version="2.4"/> | ||
| <installed facet="jst.java" version="1.8"/> |
Contributor
There was a problem hiding this comment.
I think this should be Java 17 too? Compare with the Spring Boot JCICS repo if unsure!
| <!-- Dependency Management --> | ||
| <dependencyManagement> | ||
| <dependencies> | ||
| <!-- CICS TS V6.1 BOM (as of Sept 2024) --> |
Contributor
There was a problem hiding this comment.
Is the BOM from that date? I think it's better to remove the date comment otherwise we'll always need to keep checking.
Contributor
Author
There was a problem hiding this comment.
true its better to remove,done
IvanHargreaves
requested changes
Jul 27, 2026
IvanHargreaves
left a comment
IvanHargreaves
left a comment
Contributor
There was a problem hiding this comment.
Just a couple of tweaks I've spotted.
- Update jst.java facet version from 1.8 to 17 - Update jst.web facet version from 2.4 to 6.0 (servlet-6.0) - Remove stale date comment from CICS TS BOM dependency
IvanHargreaves
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.