Fix/bank empty containers widget - #1866
Merged
chsami merged 1 commit intoSep 19, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. Walkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The fix enables emptyContainers() to activate the correct bank action and is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Rs2Bank.emptyContainers() clicked widget 786471, which decodes to (12,39) - a non-interactable LINE decoration in the bank interface, not a button. The call failed silently rather than loudly: getWidget() returned non-null so the null guard passed, clickWidget() dispatched against a widget with no actions, and the method still returned true. Callers saw success and no containers were ever emptied. Use InterfaceID.Bankmain.DEPOSITCONTAINERS = (12,45) instead. Verified against a live client at the Grand Exchange: (12,45) is the GRAPHIC carrying the "Empty containers" action with interactable: true, while (12,39) reports type LINE with an empty action list. emptyContainers() has no in-tree callers but is public API surface, so every external script calling it has been a no-op. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
HazeyByte
force-pushed
the
fix/bank-empty-containers-widget-id
branch
from
September 18, 2026 06:51
8c95d43 to
16fe594
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rs2Bank.emptyContainers() was clicking the wrong thing. The ID it used pointed at a decorative line in the bank window instead of the button, so nothing was ever emptied - and the method still reported success.
Tested in game: a coal bag holding 27 coal now empties into the bank.