Fix waitForData crash when the socket is disconnected#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The waitForData() method added in 1.9.0 calls stream_select() without checking that the socket resource still exists. When the peer closes the connection, receive() detects EOF and disconnects the socket, setting the underlying resource to null, so a subsequent waitForData() call passes null to stream_select(), which throws a ValueError on PHP 8 that the @ suppression cannot catch. This surfaced as a flaky teardown failure in chrome-php/chrome, where Chrome 140 closes the DevTools WebSocket during shutdown while the client is still waiting for a response. This change makes AbstractSocket::waitForData() return null when the socket is gone, matching the documented error contract of that method, and makes Client::waitForData() check the connection state first, consistent with sendData() and receive().