Skip to content

fix: log HTTP response body on error in all integration clients #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chitcommit merged 2 commits into from
Mar 26, 2026
Merged

fix: log HTTP response body on error in all integration clients #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50a0e97
fix: address PR review — SQL branching, error distinguishability, try…
chitcommit Mar 26, 2026
72f01b1
fix: log HTTP response body on non-ok status in all integration clients
chitcommit Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 42 additions & 22 deletions src/lib/integrations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ import type { Env } from '../index';
* All calls are fire-and-forget safe — failures are logged but don't break the caller.
*/

/** Distinguishes "no data" from "service error" for array-returning methods */
export interface ServiceArrayResult<T> {
data: T[];
error?: string;
status?: number;
}

// ── ChittyLedger ─────────────────────────────────────────────
// Audit trail: entries, chain verification, custody queries
// NOTE: Evidence/case operations live on ChittyEvidence, not ChittyLedger.
Expand Down Expand Up @@ -34,7 +41,7 @@ export function ledgerClient(env: Env) {
async function get<T>(path: string): Promise<T | null> {
try {
const res = await fetch(`${baseUrl}${path}`, { headers });
if (!res.ok) { console.error(`[ledger] GET ${path} failed: ${res.status}`); return null; }
if (!res.ok) { const body = await res.text().catch(() => ''); console.error(`[ledger] GET ${path} failed: ${res.status} — ${body.slice(0, 500)}`); return null; }
return await res.json() as T;
} catch (err) { console.error(`[ledger] GET ${path} error:`, err); return null; }
}
Expand All @@ -44,7 +51,7 @@ export function ledgerClient(env: Env) {
const res = await fetch(`${baseUrl}${path}`, {
method: 'POST', headers: { ...headers, 'Content-Type': 'application/json' }, body: JSON.stringify(body),
});
if (!res.ok) { console.error(`[ledger] POST ${path} failed: ${res.status}`); return null; }
if (!res.ok) { const errBody = await res.text().catch(() => ''); console.error(`[ledger] POST ${path} failed: ${res.status} — ${errBody.slice(0, 500)}`); return null; }
return await res.json() as T;
} catch (err) { console.error(`[ledger] POST ${path} error:`, err); return null; }
}
Expand All @@ -54,17 +61,22 @@ export function ledgerClient(env: Env) {
addEntry: (entry: LedgerEntryPayload) =>
post<{ id: string; sequenceNumber: number; hash: string }>('/entries', entry),

/** Search ledger entries */
searchEntries: async (params: { entityType?: string; entityId?: string; actor?: string; status?: string; limit?: number }): Promise<Record<string, unknown>[]> => {
/** Search ledger entries — returns { data, error? } to distinguish empty from failure */
searchEntries: async (params: { entityType?: string; entityId?: string; actor?: string; status?: string; limit?: number }): Promise<ServiceArrayResult<Record<string, unknown>>> => {
const qs = new URLSearchParams(
Object.entries(params).filter(([, v]) => v !== undefined).map(([k, v]) => [k, String(v)] as [string, string])
).toString();
return await get<Record<string, unknown>[]>(`/entries${qs ? `?${qs}` : ''}`) ?? [];
const result = await get<Record<string, unknown>[]>(`/entries${qs ? `?${qs}` : ''}`);
if (result === null) return { data: [], error: 'ChittyLedger unreachable or returned error' };
return { data: result };
},

/** Get chain of custody for an entity */
getChainOfCustody: async (entityId: string) =>
await get<Record<string, unknown>[]>(`/custody/${encodeURIComponent(entityId)}`) ?? [],
/** Get chain of custody for an entity — returns { data, error? } to distinguish empty from failure */
getChainOfCustody: async (entityId: string): Promise<ServiceArrayResult<Record<string, unknown>>> => {
const result = await get<Record<string, unknown>[]>(`/custody/${encodeURIComponent(entityId)}`);
if (result === null) return { data: [], error: 'ChittyLedger unreachable or returned error' };
return { data: result };
},

/** Verify ledger chain integrity */
verifyChain: () => get<{ valid: boolean; errors: string[] }>('/verify'),
Expand Down Expand Up @@ -115,7 +127,7 @@ export function evidenceClient(env: Env) {
async function get<T>(path: string): Promise<T | null> {
try {
const res = await fetch(`${baseUrl}${path}`, { headers });
if (!res.ok) { console.error(`[evidence] GET ${path} failed: ${res.status}`); return null; }
if (!res.ok) { const body = await res.text().catch(() => ''); console.error(`[evidence] GET ${path} failed: ${res.status} — ${body.slice(0, 500)}`); return null; }
return await res.json() as T;
} catch (err) {
console.error(`[evidence] GET ${path} error:`, err);
Expand All @@ -130,7 +142,7 @@ export function evidenceClient(env: Env) {
headers: { ...headers, 'Content-Type': 'application/json' },
body: JSON.stringify(body),
});
if (!res.ok) { console.error(`[evidence] POST ${path} failed: ${res.status}`); return null; }
if (!res.ok) { const errBody = await res.text().catch(() => ''); console.error(`[evidence] POST ${path} failed: ${res.status} — ${errBody.slice(0, 500)}`); return null; }
return await res.json() as T;
} catch (err) {
console.error(`[evidence] POST ${path} error:`, err);
Expand Down Expand Up @@ -224,7 +236,7 @@ export function financeClient(env: Env) {
const res = await fetch(`${baseUrl}${path}`, {
headers: { 'X-Source-Service': 'chittycommand' },
});
if (!res.ok) return null;
if (!res.ok) { const body = await res.text().catch(() => ''); console.error(`[finance] GET ${path} failed: ${res.status} — ${body.slice(0, 500)}`); return null; }
return await res.json() as T;
} catch (err) {
console.error(`[finance] ${path} error:`, err);
Expand Down Expand Up @@ -276,7 +288,8 @@ export function chargeClient(env: Env) {
body: JSON.stringify(body),
});
if (!res.ok) {
console.error(`[charge] ${path} failed: ${res.status}`);
const errBody = await res.text().catch(() => '');
console.error(`[charge] POST ${path} failed: ${res.status} — ${errBody.slice(0, 500)}`);
return null;
}
return await res.json() as T;
Expand Down Expand Up @@ -423,7 +436,8 @@ export function connectClient(env: Env) {
signal: AbortSignal.timeout(30000),
});
if (!res.ok) {
console.error(`[connect] POST ${path} failed: ${res.status}`);
const errBody = await res.text().catch(() => '');
console.error(`[connect] POST ${path} failed: ${res.status} — ${errBody.slice(0, 500)}`);
return null;
}
return await res.json() as T;
Expand Down Expand Up @@ -452,7 +466,7 @@ export function connectClient(env: Env) {
const res = await fetch(`${baseUrl}/api/discover/${encodeURIComponent(serviceName)}`, {
headers: { 'X-Source-Service': 'chittycommand' },
});
if (!res.ok) { console.error(`[connect/discover] ${serviceName} failed: ${res.status}`); return null; }
if (!res.ok) { const body = await res.text().catch(() => ''); console.error(`[connect/discover] ${serviceName} failed: ${res.status} — ${body.slice(0, 500)}`); return null; }
const data = await res.json() as { url: string };
// Store in KV with TTL
try { await env.COMMAND_KV.put(key, JSON.stringify({ url: data.url }), { expirationTtl: 300 }); } catch (err) { console.warn('[connect/discover] KV write failed:', err); }
Expand Down Expand Up @@ -543,7 +557,8 @@ export function mercuryClient(token: string) {
headers: { Authorization: `Bearer ${token}`, Accept: 'application/json' },
});
if (!res.ok) {
console.error(`[mercury] ${path} failed: ${res.status}`);
const body = await res.text().catch(() => '');
console.error(`[mercury] GET ${path} failed: ${res.status} — ${body.slice(0, 500)}`);
return null;
}
return await res.json() as T;
Expand Down Expand Up @@ -578,7 +593,7 @@ export function booksClient(env: Env) {
const res = await fetch(`${baseUrl}/api/summary`, {
headers: { 'X-Source-Service': 'chittycommand' },
});
if (!res.ok) return null;
if (!res.ok) { const body = await res.text().catch(() => ''); console.error(`[books] GET /api/summary failed: ${res.status} — ${body.slice(0, 500)}`); return null; }
return await res.json() as Record<string, unknown>;
} catch (err) {
console.error('[books] summary error:', err);
Expand All @@ -594,7 +609,8 @@ export function booksClient(env: Env) {
body: JSON.stringify(payload),
});
if (!res.ok) {
console.error(`[books] record-transaction failed: ${res.status}`);
const errBody = await res.text().catch(() => '');
console.error(`[books] POST /api/transaction failed: ${res.status} — ${errBody.slice(0, 500)}`);
return null;
}
return await res.json() as Record<string, unknown>;
Expand All @@ -618,7 +634,7 @@ export function assetsClient(env: Env) {
const res = await fetch(`${baseUrl}${path}`, {
headers: { 'X-Source-Service': 'chittycommand' },
});
if (!res.ok) return null;
if (!res.ok) { const body = await res.text().catch(() => ''); console.error(`[assets] GET ${path} failed: ${res.status} — ${body.slice(0, 500)}`); return null; }
return await res.json() as T;
} catch (err) {
console.error(`[assets] ${path} error:`, err);
Expand All @@ -634,7 +650,8 @@ export function assetsClient(env: Env) {
body: JSON.stringify(body),
});
if (!res.ok) {
console.error(`[assets] ${path} failed: ${res.status}`);
const errBody = await res.text().catch(() => '');
console.error(`[assets] POST ${path} failed: ${res.status} — ${errBody.slice(0, 500)}`);
return null;
}
return await res.json() as T;
Expand Down Expand Up @@ -672,7 +689,8 @@ export function scrapeClient(env: Env) {
signal: AbortSignal.timeout(30000),
});
if (!res.ok) {
console.error(`[scrape] ${path} failed: ${res.status}`);
const errBody = await res.text().catch(() => '');
console.error(`[scrape] POST ${path} failed: ${res.status} — ${errBody.slice(0, 500)}`);
return null;
}
return await res.json() as T;
Expand Down Expand Up @@ -734,7 +752,8 @@ export function routerClient(env: Env) {
signal: AbortSignal.timeout(60000),
});
if (!res.ok) {
console.error(`[router] ${path} failed: ${res.status}`);
const errBody = await res.text().catch(() => '');
console.error(`[router] POST ${path} failed: ${res.status} — ${errBody.slice(0, 500)}`);
return null;
}
return await res.json() as T;
Expand All @@ -752,7 +771,8 @@ export function routerClient(env: Env) {
signal: AbortSignal.timeout(10000),
});
if (!res.ok) {
console.error(`[router] GET ${path} failed: ${res.status}`);
const body = await res.text().catch(() => '');
console.error(`[router] GET ${path} failed: ${res.status} — ${body.slice(0, 500)}`);
return null;
}
return await res.json() as T;
Expand Down
23 changes: 14 additions & 9 deletions src/routes/mcp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,16 +1225,21 @@ async function executeTool(env: Env, sql: NeonQueryFunction<false, false>, toolN
// Facts from ChittyEvidence
const evidence = evidenceClient(env);
if (evidence) {
const facts = startDate && endDate
? await evidence.getFactsByDateRange(caseId, startDate, endDate)
: await evidence.getEnrichedFacts(caseId);
if (facts) {
for (const f of facts) {
if (!f.fact_date) continue;
events.push({ id: `fact:${f.id}`, date: f.fact_date, type: 'fact', title: f.fact_text.slice(0, 120), factType: f.fact_type, confidence: f.confidence, status: f.verification_status });
try {
const facts = startDate && endDate
? await evidence.getFactsByDateRange(caseId, startDate, endDate)
: await evidence.getEnrichedFacts(caseId);
if (facts) {
for (const f of facts) {
if (!f.fact_date) continue;
events.push({ id: `fact:${f.id}`, date: f.fact_date, type: 'fact', title: f.fact_text.slice(0, 120), factType: f.fact_type, confidence: f.confidence, status: f.verification_status });
}
} else {
warnings.push('Failed to fetch facts from ChittyEvidence');
}
} else {
warnings.push('Failed to fetch facts from ChittyEvidence');
} catch (err) {
console.error('[mcp/get_case_timeline] evidence facts error:', err);
warnings.push('Evidence facts unavailable: service error');
}
} else {
warnings.push('ChittyEvidence not configured');
Expand Down
18 changes: 10 additions & 8 deletions src/routes/timeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,16 @@ timelineRoutes.get('/cases/:caseId/timeline', async (c) => {
// 2. Fetch legal deadlines from ChittyCommand DB
const sql = getDb(c.env);
try {
const deadlines = await sql`
SELECT id, title, description, deadline_date, deadline_type, status, urgency_score
FROM cc_legal_deadlines
WHERE case_ref = ${caseId}
${startDate ? sql`AND deadline_date >= ${startDate}` : sql``}
${endDate ? sql`AND deadline_date <= ${endDate}` : sql``}
ORDER BY deadline_date ASC
`;
let deadlines;
if (startDate && endDate) {
deadlines = await sql`SELECT id, title, description, deadline_date, deadline_type, status, urgency_score FROM cc_legal_deadlines WHERE case_ref = ${caseId} AND deadline_date >= ${startDate} AND deadline_date <= ${endDate} ORDER BY deadline_date ASC`;
} else if (startDate) {
deadlines = await sql`SELECT id, title, description, deadline_date, deadline_type, status, urgency_score FROM cc_legal_deadlines WHERE case_ref = ${caseId} AND deadline_date >= ${startDate} ORDER BY deadline_date ASC`;
} else if (endDate) {
deadlines = await sql`SELECT id, title, description, deadline_date, deadline_type, status, urgency_score FROM cc_legal_deadlines WHERE case_ref = ${caseId} AND deadline_date <= ${endDate} ORDER BY deadline_date ASC`;
} else {
deadlines = await sql`SELECT id, title, description, deadline_date, deadline_type, status, urgency_score FROM cc_legal_deadlines WHERE case_ref = ${caseId} ORDER BY deadline_date ASC`;
}
for (const d of deadlines) {
events.push({
id: `deadline:${d.id}`,
Expand Down
Loading