Skip to content

docs: fix documentation drift#1248

Merged
chimurai merged 1 commit into
masterfrom
update-documentation-drift
May 24, 2026
Merged

docs: fix documentation drift#1248
chimurai merged 1 commit into
masterfrom
update-documentation-drift

Conversation

@chimurai
Copy link
Copy Markdown
Owner

@chimurai chimurai commented May 24, 2026

Summary by CodeRabbit

  • Documentation
    • Documented IPv6 unspecified hostname target handling and normalization
    • Updated router callback documentation with parameter signatures for string and object targets
    • Clarified WebSocket upgrade requirements and middleware behavior across multiple servers
    • Enhanced Node.js 17+ IPv6 configuration notes

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7f448341-e6cc-431c-b8bd-839c95a704b8

📥 Commits

Reviewing files that changed from the base of the PR and between 39a47ab and 1d5eaec.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • README.md
  • recipes/router.md
  • recipes/websocket.md

📝 Walkthrough

Walkthrough

This PR updates documentation and changelog entries to describe three related changes: router callbacks now accept (req, res, options) with res undefined during WebSocket upgrades; WebSocket upgrade subscriptions require an initial HTTP request and separate requests per server; and unspecified IPv6 hosts like [::]:port normalize to ::1.

Changes

Documentation Updates

Layer / File(s) Summary
Router API signature and examples
README.md, recipes/router.md
Router callback examples updated to show (req, res, options) signature in both string-target and object-target forms; async router and custom router recipe examples demonstrate parameter shape; note clarifies res is undefined during WebSocket upgrade flows.
WebSocket upgrade requirements and multi-server notes
README.md, recipes/websocket.md
Documentation clarified that an initial HTTP request is required to subscribe to server upgrade events, and that middleware attached to multiple servers requires a separate initial HTTP request per server for upgrade subscription activation.
IPv6 unspecified host normalization
CHANGELOG.md, README.md
Changelog entry added for IPv6 fix; README notes document that unspecified IPv6 hosts like http://[::]:port normalize to ::1 for local listeners.

Possibly related PRs

Poem

🐰 A rabbit hops through docs so fine,
Routing requests, one line at a line,
WebSocket notes shine crisp and clear,
IPv6 paths—the way is here! ✨


🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'docs: fix documentation drift' directly and accurately describes the main change in the pull request, which consists entirely of documentation updates across multiple markdown files (CHANGELOG.md, README.md, recipes/router.md, recipes/websocket.md) to align documentation with current functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-documentation-drift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 24, 2026

npm i https://pkg.pr.new/http-proxy-middleware@1248

commit: 1d5eaec

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 94.656%. remained the same — update-documentation-drift into master

@chimurai chimurai merged commit 5a78782 into master May 24, 2026
25 of 26 checks passed
@chimurai chimurai deleted the update-documentation-drift branch May 24, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants