You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The only thing left to do is to update the existing documentation. There are many, I mean, many markdown files. Some of them are for Docusaurus, some of them are for Astro. I was going to update it but I'm kind of confused. Can you inform me about how the docs build?
The option semantics look inverted. With options = { read: false } as default, read is false, so if (read) return is skipped and reading still runs — the default behavior is preserved by accident. But that means read: true actually disables reading, which is the opposite of what the name implies.
To keep this non-breaking and intuitive, I'd suggest defaulting read to true (= "reading is enabled", current behavior), and letting users opt out with read: false when they only need writing:
Also: please add a test for the read: false path, and update the docs under packages/website-astro/src/content/docs/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #200
Type of Change
Checklist
The only thing left to do is to update the existing documentation. There are many, I mean, many markdown files. Some of them are for Docusaurus, some of them are for Astro. I was going to update it but I'm kind of confused. Can you inform me about how the docs build?