This repository was archived by the owner on Sep 23, 2025. It is now read-only.
Define an AMD module if require.js is loaded#248
Open
m-amr wants to merge 1 commit intochieffancypants:masterfrom
Open
Define an AMD module if require.js is loaded#248m-amr wants to merge 1 commit intochieffancypants:masterfrom
m-amr wants to merge 1 commit intochieffancypants:masterfrom
Conversation
| * define AMD module | ||
| */ | ||
|
|
||
| if(typeof define === 'function') { |
Collaborator
|
LGTM but needs tests and the change I suggested. Thoughts @chieffancypants? |
Owner
|
I don't use AMD, so I can't really comment on the method used to support it. That said, I'd probably prefer it be done through the build process: https://github.com/bebraw/grunt-umd The resulting code differs a bit from what is suggested here, and seems a bit more versatile. Here's an example output: https://github.com/angular-translate/bower-angular-translate/blob/master/angular-translate.js#L6-L20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request solve this Issue
#246
At requireJs.config
1- i added this line to the pathes
loadingBar:'bower_components/angular-loading-bar/build/loading-bar.min',
2-and i use shim to add angular as dependency for that module
loadingBar: {
exports: 'loadingBar',
deps:['angular']
},
i have my mainAngularModule called appModule;
what i am trying to do is to add the loadingBar module as a dependency in my appModule
var loadingBar = require('loadingBar');
console.log(loadingBar);
//display undefined
it throw error because loadingBar is undefined
but when i added the module name as string it works
but by checking if define is a function then define an AMD module will solve the problem