This repository was archived by the owner on Sep 23, 2025. It is now read-only.
Mousetrap as dependency (not devDependency)#214
Open
Mitiryl wants to merge 1 commit intochieffancypants:masterfrom
Open
Mousetrap as dependency (not devDependency)#214Mitiryl wants to merge 1 commit intochieffancypants:masterfrom
Mitiryl wants to merge 1 commit intochieffancypants:masterfrom
Conversation
|
@Mitiryl Mousetrap is bundled into the angular-hotkeys library, so users of the package don't need it as a separate dependency. It's only required for those wishing to produce new builds of the angular-hotkeys library, so devDependencies is the correct place for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mousetrap is needed to load library so it should be put as dependency and not as devDependency.