You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved clarity in File Opening UI by updating dropdown labels and descriptions. Split direction options now use "Split right" and "Split down" terminology with enhanced descriptive guidance for better user understanding.
✏️ Tip: You can customize this high-level summary in your review settings.
The "Horizontal" and "Vertical" labels were confusing because Obsidian's
SplitDirection refers to the divider orientation, not the pane placement.
This led users to select "Horizontal" expecting a horizontal layout, but
getting side-by-side panes instead.
Changed labels to describe where the new pane appears:
- "vertical" → "Split right" (vertical divider, panes side by side)
- "horizontal" → "Split down" (horizontal divider, panes stacked)
Fixes#1081
Two UI components had their "Split direction" setting labels updated. The description text and dropdown option labels were changed for improved clarity. "Vertical" and "Horizontal" options were renamed to "Split right" and "Split down" respectively. No functional or logic changes.
Changes
Cohort / File(s)
Summary
UI Label Updates for Split Direction Setting src/gui/ChoiceBuilder/choiceBuilder.ts, src/gui/MacroGUIs/OpenFileCommandSettingsModal.ts
Updated "Split direction" description from "Direction for split panes" to "How to arrange the new pane relative to the current one". Renamed dropdown options: "Vertical" → "Split right" and "Horizontal" → "Split down".
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
A rabbit hops with glee so bright,
The labels now say "down" and "right,"
No more confusion, crystal clear,
How panes shall split, without a fear!
Left, right, up, down—the words align,
This clarity? Simply divine! 🐰
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Summary
Root Cause
Obsidian's
SplitDirectionrefers to divider orientation, not pane placement:"vertical"= vertical divider = panes side by side (split right)"horizontal"= horizontal divider = panes stacked (split down)The old labels caused users to select "Horizontal" expecting stacked panes, but getting side-by-side instead.
Test plan
Fixes #1081
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.